Add substring util #806
Merged
Add substring util #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VipulMascarenhas
requested review from
darenr,
mayoor,
mrDzurb and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
mayoor
reviewed
Apr 24, 2024
ads/aqua/utils.py
Outdated
| @@ -741,3 +741,9 @@ def known_realm(): | |||
|
|
|||
| """ | |||
| return os.environ.get("CONDA_BUCKET_NS") in AQUA_GA_LIST | |||
|
|
|||
|
|
|||
| def get_ocid_substring(ocid: str, key_len: int = 8) -> str: | |||
There was a problem hiding this comment.
What is the significance of 8 characters in ocid?
There was a problem hiding this comment.
no significance, I removed the defaults.
mayoor
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added util function as per review comments.