Skip to content

improve usage of using blocks #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dmcgiv
Copy link

@dmcgiv dmcgiv commented Dec 31, 2018

no need for separate using braces with the two adjacent using blocks
reader is disposable so should be in a using block

no need for separate using braces with the two adjacent using blocks
reader is disposable so should be in a using block
Copy link
Member

@alexkeh alexkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of adding braces is to make the sample code easily extensible. A developer can take the existing code without having to add the braces themselves, which they may not realize they need to do.

I can accept your DataReader using block change. Can you resubmit with the DataReader change only?

Also, Oracle requires code contributors to sign the Oracle Contributor Agreement (OCA) to protect our joint copyrights in the code. Can you accept the OCA and then re-submit with your name and email. More info on the OCA and what to do is here: https://github.com/oracle/dotnet-db-samples/blob/master/CONTRIBUTING.md

@alexkeh
Copy link
Member

alexkeh commented Feb 17, 2019

Closing the pull request since there's been no response for a month. Feel free to re-open and submit the modified change.

@alexkeh alexkeh closed this Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants