Skip to content

Create opentelemetry.cs #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Create opentelemetry.cs #322

merged 1 commit into from
Oct 23, 2023

Conversation

alexkeh
Copy link
Member

@alexkeh alexkeh commented Oct 20, 2023

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 20, 2023
@alexkeh alexkeh requested a review from christianshay October 21, 2023 18:12
@alexkeh alexkeh merged commit 96fba8f into master Oct 23, 2023
@alexkeh alexkeh deleted the alexkeh-patch-4 branch October 23, 2023 17:17
sungam3r
sungam3r reviewed Oct 31, 2023
View reviewed changes
samples/opentelemetry/opentelemetry.cs
//.AddZipkinExporter() // OpenTelemetry.Exporter.Zipkin NuGet package extension method
.Build()!;

static ActivitySource activitySource = new ActivitySource("ODPNET");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ODPNET -> ODP.NET App?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianshay christianshay christianshay approved these changes

+1 more reviewer

@sungam3r sungam3r sungam3r left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkeh @christianshay @sungam3r