Skip to content

Fix MonitorReader.close() #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fix MonitorReader.close() #273

merged 1 commit into from
Aug 14, 2020

Conversation

@romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Aug 14, 2020

Wrap consumeLines with try/catch/finally in MonitorReader.close()

@romain-grecourt romain-grecourt added this to the 2.0.3 milestone Aug 14, 2020
@romain-grecourt romain-grecourt self-assigned this Aug 14, 2020
@batsatt batsatt merged commit 2e54587 into helidon-io:master Aug 14, 2020
@romain-grecourt romain-grecourt deleted the fix-monitor-reader-close branch August 18, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@batsatt batsatt batsatt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romain-grecourt romain-grecourt

Labels

cli

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@romain-grecourt @batsatt