Windows support #319
Merged
Windows support #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set logOutput to true in ClassDataSharingTest
…nitCommandBaseTest This removes the state of the base test class fields, and gives a fluent API for readability. Without state it is now easy to generate a unique project directory. Fix init --project to be the acutal project directory as documented rather than the parent directory of the project directory to create. Add/update javadocs.
…to replace \r\n with \n
…or windows path in pipeline-env.bat
batsatt
suggested changes
Oct 29, 2020
helidon-cli/impl/src/test/java/io/helidon/build/cli/impl/InitCommandInvoker.java
Outdated
Show resolved
Hide resolved
helidon-linker/src/test/java/io/helidon/linker/ClassDataSharingTest.java
Show resolved
Hide resolved
helidon-linker/src/test/java/io/helidon/linker/ClassDataSharingTest.java
Show resolved
Hide resolved
helidon-cli/impl/src/test/java/io/helidon/build/cli/impl/TestUtils.java
Outdated
Show resolved
Hide resolved
helidon-cli/impl/src/test/java/io/helidon/build/cli/impl/MetadataTestBase.java
Show resolved
Hide resolved
helidon-cli/impl/src/test/java/io/helidon/build/cli/impl/MetadataTestBase.java
Outdated
Show resolved
Hide resolved
helidon-cli/impl/src/test/java/io/helidon/build/cli/impl/MetadataTestBase.java
Outdated
Show resolved
Hide resolved
…t not just about init anymore.
This was referenced Nov 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalize the windows support with a fully working pipeline passing all the unit tests, as well as a native-image windows build.