Update cli codegen #366
Merged
Update cli codegen #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in Java. Add an type information abstraction "TypeInfo" that unifies typo information (pseudo, class, processing) under a single type. - Unifies typo information for pseudo types, existing classes, processing elements - Used in the visitor, annotation meta-models and ast objects Add a javac plugin to get the file header (i.e copyright header) of the annotated types, and add it to the generated sources. - Plugin must be configured with -XPlugin:file-header for this to work ; it is optional Renamed AnnotationProcessor to CommandAP Add unit tests for AST, TypeInfo and CommandAP Remove CLIDefinition and replace it with a @commandlineinterface Move Config/UserConfig from harness to impl - Decoupled Config / UserConfig with a concept of InternalOptions. - Internal options duplicates the constants for the config required by the harness - Internal options uses a lookup function to fetch the values - The CLI main method provides a lookup function to bind - Added a Builder to CommandRunner / CommandContext to bootstrap the CLI Fixed MetadataAccessTestBase to not be order dependent. - Reset the user config every time to avoid unexpected config set by a prior test Restore and fix a few module-infos. Changed CLI main class from Main to Helidon.
barchetta
approved these changes
Mar 24, 2021
romain-grecourt
added a commit
to romain-grecourt/helidon-build-tools
that referenced
this pull request
Apr 27, 2021
* Add a simple AST API to codegen to model and render the generated code in Java. Add an type information abstraction "TypeInfo" that unifies typo information (pseudo, class, processing) under a single type. - Unifies typo information for pseudo types, existing classes, processing elements - Used in the visitor, annotation meta-models and ast objects Add a javac plugin to get the file header (i.e copyright header) of the annotated types, and add it to the generated sources. - Plugin must be configured with -XPlugin:file-header for this to work ; it is optional Renamed AnnotationProcessor to CommandAP Add unit tests for AST, TypeInfo and CommandAP Remove CLIDefinition and replace it with a @commandlineinterface Move Config/UserConfig from harness to impl - Decoupled Config / UserConfig with a concept of InternalOptions. - Internal options duplicates the constants for the config required by the harness - Internal options uses a lookup function to fetch the values - The CLI main method provides a lookup function to bind - Added a Builder to CommandRunner / CommandContext to bootstrap the CLI Fixed MetadataAccessTestBase to not be order dependent. - Reset the user config every time to avoid unexpected config set by a prior test Restore and fix a few module-infos. Changed CLI main class from Main to Helidon. * Update visitor, remove the anonymous visitor implementation as that seems to crash javac * remove visitor singletons * fix new test on windows * fix new test on windows (cherry picked from commit 830cf07)
romain-grecourt
added a commit
that referenced
this pull request
Apr 28, 2021
* Add a simple AST API to codegen to model and render the generated code in Java. Add an type information abstraction "TypeInfo" that unifies typo information (pseudo, class, processing) under a single type. - Unifies typo information for pseudo types, existing classes, processing elements - Used in the visitor, annotation meta-models and ast objects Add a javac plugin to get the file header (i.e copyright header) of the annotated types, and add it to the generated sources. - Plugin must be configured with -XPlugin:file-header for this to work ; it is optional Renamed AnnotationProcessor to CommandAP Add unit tests for AST, TypeInfo and CommandAP Remove CLIDefinition and replace it with a @commandlineinterface Move Config/UserConfig from harness to impl - Decoupled Config / UserConfig with a concept of InternalOptions. - Internal options duplicates the constants for the config required by the harness - Internal options uses a lookup function to fetch the values - The CLI main method provides a lookup function to bind - Added a Builder to CommandRunner / CommandContext to bootstrap the CLI Fixed MetadataAccessTestBase to not be order dependent. - Reset the user config every time to avoid unexpected config set by a prior test Restore and fix a few module-infos. Changed CLI main class from Main to Helidon. * Update visitor, remove the anonymous visitor implementation as that seems to crash javac * remove visitor singletons * fix new test on windows * fix new test on windows (cherry picked from commit 830cf07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI code generation update.
Remove CLIDefinition and replaced it with a @commandlineinterface
Move Config/UserConfig from harness to impl
Fixed MetadataAccessTestBase to not be order dependent.
Restore and fix a few module-infos.
Changed CLI main class from Main to Helidon.