Skip to content

Conversation

@romain-grecourt
Copy link
Contributor

@romain-grecourt romain-grecourt commented Mar 26, 2021

Add support for embedded plugin execution if the plugin class is loadable.

  • Make PluginFailed a runtime exception instead of a checked exception
  • Update Metadata to remove all the un-necessary exception handling
  • Wrap IOException with UncheckedIOException where needed
  • Add a builder to Metadata.
  • Remove InitCommandSimpleTest
  • Update MetadataAccessTest to remove the assertions related to forked plugin execution.

…able.

Make PluginFailed a runtime exception instead of a checked exception
Update Metadata to remove all the un-necessary exception handling
Wrap IOException with UncheckedIOException where needed
Add a builder to Metadata.
Remove InitCommandSimpleTest
Update MetadataAccessTest to remove the assertions related to forked plugin execution.
@romain-grecourt romain-grecourt merged commit ac906d2 into helidon-io:master Mar 26, 2021
@romain-grecourt romain-grecourt deleted the cli-plugins-embedded branch March 26, 2021 01:07
@romain-grecourt romain-grecourt added this to the 3.0.0 milestone Mar 26, 2021
romain-grecourt added a commit to romain-grecourt/helidon-build-tools that referenced this pull request Apr 27, 2021
…able. (helidon-io#367)

Make PluginFailed a runtime exception instead of a checked exception
Update Metadata to remove all the un-necessary exception handling
Wrap IOException with UncheckedIOException where needed
Add a builder to Metadata.
Remove InitCommandSimpleTest
Update MetadataAccessTest to remove the assertions related to forked plugin execution.

(cherry picked from commit ac906d2)
romain-grecourt added a commit that referenced this pull request Apr 28, 2021
…able. (#367)

Make PluginFailed a runtime exception instead of a checked exception
Update Metadata to remove all the un-necessary exception handling
Wrap IOException with UncheckedIOException where needed
Add a builder to Metadata.
Remove InitCommandSimpleTest
Update MetadataAccessTest to remove the assertions related to forked plugin execution.

(cherry picked from commit ac906d2)
@romain-grecourt romain-grecourt modified the milestones: 3.0.0, 3.0.0-M2, 2.2.0 Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants