Fix and improve plugins #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able. Make PluginFailed a runtime exception instead of a checked exception Update Metadata to remove all the un-necessary exception handling Wrap IOException with UncheckedIOException where needed Add a builder to Metadata. Remove InitCommandSimpleTest Update MetadataAccessTest to remove the assertions related to forked plugin execution.
- Use org.graalvm.nativeimage.ImageInfo.inImageRuntimeCode() - if in native-image spawn the execution, otherwise do it in-jvm. Only bundle the plugin JAR as a resource in the native-image binary - stage it under target/native instead of target/classes - use manual class-path for native-image to include target/native Replace BuildToolsProperties with Config.buildProperties and static method for buildVersion and buildRevision - This ensures that the file name of the plugin JAR bundled in the CLI will NEVER be out of sync. Make all classes under plugin non public, except the Plugin class.
romain-grecourt
force-pushed
the
build-info-props-cli
branch
from
81887db to
24e093d
Compare
romain-grecourt
changed the title
romain-grecourt
changed the title
barchetta
approved these changes
Mar 26, 2021
romain-grecourt
added a commit
to romain-grecourt/helidon-build-tools
that referenced
this pull request
Apr 27, 2021
* Add support for embedded plugin execution if the plugin class is loadable. Make PluginFailed a runtime exception instead of a checked exception Update Metadata to remove all the un-necessary exception handling Wrap IOException with UncheckedIOException where needed Add a builder to Metadata. Remove InitCommandSimpleTest Update MetadataAccessTest to remove the assertions related to forked plugin execution. * Fix and improve plugins execution: - Use org.graalvm.nativeimage.ImageInfo.inImageRuntimeCode() - if in native-image spawn the execution, otherwise do it in-jvm. Only bundle the plugin JAR as a resource in the native-image binary - stage it under target/native instead of target/classes - use manual class-path for native-image to include target/native Replace BuildToolsProperties with Config.buildProperties and static method for buildVersion and buildRevision - This ensures that the file name of the plugin JAR bundled in the CLI will NEVER be out of sync. Make all classes under plugin non public, except the Plugin class. (cherry picked from commit e9fbd1f)
romain-grecourt
added a commit
that referenced
this pull request
Apr 28, 2021
* Add support for embedded plugin execution if the plugin class is loadable. Make PluginFailed a runtime exception instead of a checked exception Update Metadata to remove all the un-necessary exception handling Wrap IOException with UncheckedIOException where needed Add a builder to Metadata. Remove InitCommandSimpleTest Update MetadataAccessTest to remove the assertions related to forked plugin execution. * Fix and improve plugins execution: - Use org.graalvm.nativeimage.ImageInfo.inImageRuntimeCode() - if in native-image spawn the execution, otherwise do it in-jvm. Only bundle the plugin JAR as a resource in the native-image binary - stage it under target/native instead of target/classes - use manual class-path for native-image to include target/native Replace BuildToolsProperties with Config.buildProperties and static method for buildVersion and buildRevision - This ensures that the file name of the plugin JAR bundled in the CLI will NEVER be out of sync. Make all classes under plugin non public, except the Plugin class. (cherry picked from commit e9fbd1f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and improve plugins execution:
Only bundle the plugin JAR as a resource in the native-image binary
Replace BuildToolsProperties with Config.buildProperties and static method for buildVersion and buildRevision
Make all classes under plugin non public, except the Plugin class.
Fixes #370
Fixes #371