Fix aether utility to use Maven settings. #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes helidon-io#383 Both the aether and engine utility are now written in Java. - The byte code for the classes in included as base64 strings in the generated groovy script. - Improve archetype-post-generate.groovy ; add comments Update the integration-test mojo to generate the test projects with archetype:generate if mavenArchetypeCompatible==true. Add a profile debug-invoker to allo debugging invoker based integration tests. Add a settings.xml to enable better cache with the invoker plugin.
barchetta
approved these changes
Apr 27, 2021
romain-grecourt
added a commit
to romain-grecourt/helidon-build-tools
that referenced
this pull request
Apr 27, 2021
* Fix aether utility to use Maven settings. Fixes helidon-io#383 Both the aether and engine utility are now written in Java. - The byte code for the classes in included as base64 strings in the generated groovy script. - Improve archetype-post-generate.groovy ; add comments Update the integration-test mojo to generate the test projects with archetype:generate if mavenArchetypeCompatible==true. Add a profile debug-invoker to allo debugging invoker based integration tests. Add a settings.xml to enable better cache with the invoker plugin. * remove system out * fix checkstyle error * fix comments (cherry picked from commit 5e1ff0a)
romain-grecourt
added a commit
that referenced
this pull request
Apr 28, 2021
* Fix aether utility to use Maven settings. Fixes #383 Both the aether and engine utility are now written in Java. - The byte code for the classes in included as base64 strings in the generated groovy script. - Improve archetype-post-generate.groovy ; add comments Update the integration-test mojo to generate the test projects with archetype:generate if mavenArchetypeCompatible==true. Add a profile debug-invoker to allo debugging invoker based integration tests. Add a settings.xml to enable better cache with the invoker plugin. * remove system out * fix checkstyle error * fix comments (cherry picked from commit 5e1ff0a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
Both the aether and engine utility are now written in Java.
Update the integration-test mojo to generate the test projects with archetype:generate if mavenArchetypeCompatible==true.
Add a profile debug-invoker to allo debugging invoker based integration tests.
Add a settings.xml to enable better cache with the invoker plugin.