[BUG] Fix aiohttp dep issue #23
Conversation
YouNeedCryDear
requested review from
piyushg,
ashutoshSce,
mrDzurb,
streamnsight and
qiuosier
oracle-contributor-agreement
bot
added
the
OCA Verified
|
does it prevent the package from loading? or is it only necessary when using the DS deployment? If the later we should make this an optional dependency |
| pydantic = ">=2,<3" | ||
| # aiohttp = ">=3.12.14" | ||
| aiohttp = ">=3.12.14" | ||
|
|
There was a problem hiding this comment.
does it prevent the package from loading? or is it only necessary when using the DS deployment? If the later we should make this an optional dependency
There was a problem hiding this comment.
Making aiohttp required or optional here will likely have little impact since aiohttp is a dependency of LangChain.
There was a problem hiding this comment.
@qiuosier Then we should remove it to avoid having version conflicts
There was a problem hiding this comment.
The release failed because of missing aiohttp. @qiuosier @streamnsight https://github.com/oracle/langchain-oracle/actions/runs/17308563396/job/49137511908
There was a problem hiding this comment.
I think the easiest way to move forward is to keep aiohttp. This is unlikely to cause version conflicts.
add aiohttp back as it is required by ds model deployment