Skip to content

[BUG] Fix aiohttp dep issue #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

[BUG] Fix aiohttp dep issue #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/oci/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ langchain-core = ">=0.3.20,<1.0.0"
langchain = ">=0.3.20,<1.0.0"
oci = ">=2.144.0"
pydantic = ">=2,<3"
# aiohttp = ">=3.12.14"
aiohttp = ">=3.12.14"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it prevent the package from loading? or is it only necessary when using the DS deployment? If the later we should make this an optional dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making aiohttp required or optional here will likely have little impact since aiohttp is a dependency of LangChain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiuosier Then we should remove it to avoid having version conflicts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release failed because of missing aiohttp. @qiuosier @streamnsight https://github.com/oracle/langchain-oracle/actions/runs/17308563396/job/49137511908

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the easiest way to move forward is to keep aiohttp. This is unlikely to cause version conflicts.

[tool.poetry.group.test]
optional = true
Expand Down