"Download" link misleading, "Raw" needed (Bugzilla #3162)

[vladak]

status ACCEPTED severity enhancement in component webapp for 0.8
Reported in version unspecified on platform Other
Assigned to: Trond Norbye

On 2008-08-29 02:11:58 +0000, Mark Phalan wrote:

There are a number of links visible when viewing a file
"Home | History | Annotate | Download"

The "Download" link is misleading - it does not necessarily lead to a download of the file but rather gives a raw view. This raw view mostly results in the file being viewed in the browser.

The current "Download" link should be changed to "Raw" or "Raw file" and a new link "Download" should be introduced which will always trigger a download of the file (using the download manager of the browser) no matter what content the file has.

On 2008-09-16 02:16:22 +0000, Jorgen Austvik wrote:

Looks like Content-Disposition should be used for the download link:

http://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html#sec19.5.1
http://support.microsoft.com/kb/260519

[vladak]

Looking into raw.jsp (which maps from Download link, e.g. https://opengrok/source/raw/xref/foo/bar.c - note the raw component) this is already done:

81    try {
82        response.setHeader("content-disposition", "attachment; filename="
83            + f.getName());

It is more about introducing another 'Raw' link which will be also using raw.jsp but without the above header or rather with content-type header of text/plain.

[vladak]

Jenkins/Chuck Norris likes this as well :-)