Multiple views of tip tag in the history

[skozina]

In the regularly running re-index with OpenGrok 0.12 on the ON gate (hg repository) we can see several appearances of the tip tag. Perhaps the tip tag needs to be removed from the latest commit on reindex?

[vladak]

caused by FileHistoryCache.java:storeFile():

229        // Incremental update of the history for this file.
230        History histOld;
231        try {
232            histOld = readCache(cache);
233            // Merge old history with the new history.
234            List<HistoryEntry> listOld = histOld.getHistoryEntries();
235            if (!listOld.isEmpty()) {
236                List<HistoryEntry> listNew = histNew.getHistoryEntries();
237                ListIterator li = listNew.listIterator(listNew.size());
238                while (li.hasPrevious()) {
239                    listOld.add(0, (HistoryEntry) li.previous());
240                }
241                history = new History(listOld);
242            }

The merging of old and new history needs to be tag aware for the latest changeset from the old history.

It is also a question whether we should be tagging with tip at all.