filtering the xref of '/' based on authorization #1618
Conversation
| * remove all which aren't among the filtered set of | ||
| * projects. | ||
| */ | ||
| list = new ArrayList<>(list); |
There was a problem hiding this comment.
I'd rather have the list variable named differently than the original, will make it easier to debug.
| */ | ||
| list = new ArrayList<>(list); | ||
| list.removeIf((t) -> { | ||
| return !getProjectHelper().getAllProjects().stream().anyMatch((p) -> { |
There was a problem hiding this comment.
what happens if projects are disabled ?
There was a problem hiding this comment.
that's a good question also for the whole auth framework
| if (getPath().isEmpty()) { | ||
| /** | ||
| * This denotes the source root directory, we need to filter | ||
| * projects which aren't allowed by the authorization. E. g. |
There was a problem hiding this comment.
adjust the comment explaining what method called below actually performs the authorization check
| List<String> list = Arrays.asList(files); | ||
| if (getPath().isEmpty()) { | ||
| /** | ||
| * This denotes the source root directory, we need to filter |
There was a problem hiding this comment.
pls explain in the comment why this only has to be done for the root dir
| @@ -377,7 +377,8 @@ public String canProcess() { | |||
| * | |||
| * @return an empty list, if the resource does not exist, is not a directory | |||
| * or an error occurred when reading it, otherwise a list of filenames in | |||
| * that directory, sorted alphabetically | |||
| * that directory, sorted alphabetically and filtered based on authorization | |||
There was a problem hiding this comment.
not precise I think as the authorization is performed only for root dir
| * | ||
| * <p> | ||
| * For the root directory (/xref/) an authorization is performed for each of | ||
| * the project in case that projects are used in OpenGrok.</p> |
There was a problem hiding this comment.
'each project' or 'each of the projects'
|
Is it possible to unit test this ? |
|
I added a simple test case for this |
fixes #1610