send Message before indexing with "set projectsEnabled = true" if run… #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning with -P fixes oracle#1678
tulinkry
approved these changes
Jul 24, 2017
| Message m = Message.createMessage("config"); | ||
| m.addTag("set"); | ||
| m.setText("projectsEnabled = true"); | ||
| m.write(host, port); |
There was a problem hiding this comment.
If this fails will the index process continue?
There was a problem hiding this comment.
If e.g. write() throws exception, It will stop.
There was a problem hiding this comment.
..which is good I think as it will avoid surprise at the end of the indexing (if the webapp is permanently down).
There was a problem hiding this comment.
I think it is not because that completely prevents you to prepare the configuration offline.
There was a problem hiding this comment.
If the host/port is not set the message will not be sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ning with -P
fixes #1678