Skip to content

removeFile() needs to be smarter to allow incremental history indexing #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2017
Merged

removeFile() needs to be smarter to allow incremental history indexing #1702

merged 4 commits into from
Aug 2, 2017

Conversation

vladak
Copy link
Member

@vladak vladak commented Jul 28, 2017 •
edited
Loading

The important piece is this line in indexDown():

removeFile(!termPath.equals(path));

@vladak vladak force-pushed the removeFile_smarter branch from 690ca08 to d091b4b Compare July 28, 2017 16:05
@vladak vladak changed the title Remove file smarter removeFile() needs to be smarter to allow incremental history indexing Jul 31, 2017
@tarzanek tarzanek added this to the 1.1 milestone Aug 2, 2017
@tarzanek
Copy link
Contributor

tarzanek commented Aug 2, 2017

thank you sir!
lgtm, merging

@tarzanek tarzanek merged commit 1027591 into oracle:master Aug 2, 2017
@vladak vladak deleted the removeFile_smarter branch July 10, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vladak vladak

Labels
None yet
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @tarzanek