various repository methods should use interactive timeout #2108
Conversation
| } | ||
|
|
||
| @Override | ||
| protected void buildTagList(File directory) { | ||
| protected void buildTagList(File directory, boolean interactive) { |
There was a problem hiding this comment.
Wondering whether the new interactive parameter should possibly be used in this method.
There was a problem hiding this comment.
good catch, yes. Also, I've just hit this when testing full reindex on a busy machine where I deliberately set the interactive timeout to 3 seconds.
| @@ -295,57 +263,23 @@ boolean hasFileBasedTags() { | |||
| * @param directory Directory where we list tags | |||
| */ | |||
| @Override | |||
| protected void buildTagList(File directory) { | |||
| protected void buildTagList(File directory, boolean interactive) { | |||
There was a problem hiding this comment.
Wondering if new interactive should be used in this method.
| @@ -613,70 +561,23 @@ boolean hasFileBasedTags() { | |||
| } | |||
|
|
|||
| @Override | |||
| protected void buildTagList(File directory) { | |||
| protected void buildTagList(File directory, boolean interactive) { | |||
There was a problem hiding this comment.
Should new interactive be used in the method?
|
In the end I decided to properly propagate the interactive flag from |
|
As for the In other words, the definition would be: whatever comes from UI/webapp is considered interactive. |
vladak
force-pushed
the
interactive_timeout
branch
from
0eddb36 to
9262904
Compare
vladak
force-pushed
the
interactive_timeout
branch
from
9262904 to
49de4b0
Compare
This change introduces interactive timeout that will be used when:
Messageor whenSearchis done using CLI)The first item basically triggers
invalidateRepositories()inHistoryGuruthat will in turn callgetRepositories(). Thus, all theRepositorycalls inside need to be made "interactive".Basically, I've modified all repositories to use
Executoras opposed toRuntimeorProcessBuilderdirectly. I don't like the way howExecutorsets up the timeout too much (it should not know aboutRuntimeEnvironmentor unsetthis.timeoutwhen it is already set. Maybe it should also have getter/setter for timeout.), however that's for next time.Also, maybe all the repository annotation/tag parsers should be an interface/abstract class however there are subtle difference how these are implemented for various repositories so for the time being I mirrored the style already used by Bitkeeper repository.
After the change there will be 3 types of timeout related behavior:
Tested with unreachable Subversion repository + webapp start and also full reindex.