add sub-repositories of the same type as parent #2817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2019 10:14
tulinkry
approved these changes
Jun 19, 2019
There was a problem hiding this comment.
I know there was the comment in the code about todooing this, however I never understood the concern here - why should we only discover and index the repositories of the same type? If the project consists of several repositories of different kind then all of them should have the history, shouldn't they?
|
This is done more for efficiency (esp. those repository types which do not just look for special files/directories but execute a command to detect a repository). Also, mixing repository types is uncommon, I think. |
|
I agree that this is an edge case. Let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restricts the discovery of sub-repositories to the type of repository already found.