-
Notifications
You must be signed in to change notification settings - Fork 786
Update ctag language regexp #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Use only short form for kinds, the long form is deprecated - Define new kinds with the --kinddef-<LANG> flag - Harmonize kind names and descriptions
Instead escaping spaces in kind definition descriptions
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/Ctags.java
Outdated
Show resolved
Hide resolved
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/Ctags.java
Outdated
Show resolved
Hide resolved
Could you please fix the tests? Otherwise looks good to me. |
Thanks for @ahornace's review!
This is tracked by #1672 |
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/Ctags.java
Outdated
Show resolved
Hide resolved
@vladak: thanks, maybe the option file stuff should be tackled in another PR anyway. Reading that issue I was wondering if there is still a requirement to support Exuberant ctags? It does not support multiple |
Yeah, definitely a topic for another PR. As for Exuberant ctags, this is long dead so the references are purely historical I'd say. If we need some OpenGrok specific changes in Universal ctags, it should not be a problem raising PR there. |
Thanks! |
This is an attempt to address #3764
Note:
The number of flags to ctags is huge. Maybe it would be worth writing all these options to an option file passed via --options=PATHNAME (as described here)
In this case the file can be part of the repository.