Skip to content

Update ctag language regexp #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 26, 2021
Merged

Update ctag language regexp #3770

merged 4 commits into from
Nov 26, 2021

Conversation

ohm314
Copy link
Contributor

@ohm314 ohm314 commented Nov 19, 2021

  • Use only short form for kinds, the long form is deprecated
  • Define new kinds with the --kinddef- flag
  • Harmonize kind names and descriptions

This is an attempt to address #3764

Note:
The number of flags to ctags is huge. Maybe it would be worth writing all these options to an option file passed via --options=PATHNAME (as described here)
In this case the file can be part of the repository.

- Use only short form for kinds, the long form is deprecated
- Define new kinds with the --kinddef-<LANG> flag
- Harmonize kind names and descriptions
@ohm314 ohm314 changed the title Update ctag language regexa Update ctag language regexp Nov 19, 2021
Instead escaping spaces in kind definition descriptions
@ahornace
Copy link
Contributor

Could you please fix the tests? Otherwise looks good to me.

@ohm314 ohm314 marked this pull request as ready for review November 21, 2021 10:47
@vladak
Copy link
Member

vladak commented Nov 22, 2021

Note: The number of flags to ctags is huge. Maybe it would be worth writing all these options to an option file passed via

This is tracked by #1672

@ohm314
Copy link
Contributor Author

ohm314 commented Nov 23, 2021

@vladak: thanks, maybe the option file stuff should be tackled in another PR anyway. Reading that issue I was wondering if there is still a requirement to support Exuberant ctags? It does not support multiple --options flags afaik and so one would have to merge the two files (which will be annoying to do 😄 )

@vladak
Copy link
Member

vladak commented Nov 23, 2021

@vladak: thanks, maybe the option file stuff should be tackled in another PR anyway. Reading that issue I was wondering if there is still a requirement to support Exuberant ctags? It does not support multiple --options flags afaik and so one would have to merge the two files (which will be annoying to do smile )

Yeah, definitely a topic for another PR. As for Exuberant ctags, this is long dead so the references are purely historical I'd say. If we need some OpenGrok specific changes in Universal ctags, it should not be a problem raising PR there.

@ahornace
Copy link
Contributor

Thanks!

@ahornace ahornace merged commit 1d90c1f into oracle:master Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants