Profiling not supported on IcedTea and AdoptOpenJDK builds

[Barteks2x]

Describe the bug
Profiling is not available for IcedTea and AdoptOpenJDK builds

To Reproduce
Run an application with IcedTea or AdoptOpenJDK JDK and attach to it with visualvm. There will be no "profiler" option.

Expected behavior
Those JVM builds should be supported.

Desktop (please complete the following information):

• OS: Linux gentoo
• JDK version IcedTea 1.8.0_212, AdoptOpenJDK 11.0.3_p7
• Version 1.4.3, also tested commit ad76e9d

Additional context
Add any other context about the problem here.
The supported JVMs are hardcoded here

visualvm/visualvm/profiler/src/org/graalvm/visualvm/profiler/ProfilerSupport.java

Lines 332 to 340 in ad76e9d

	// VM has to be a HotSpot VM or OpenJDK by Sun Microsystems Inc. or
	// Oracle Co. or Apple Inc. or Hewlett-Packard Co. or
	// Azul Systems, Inc. or SAP AG or Graal VM
	return vmName != null && (vmName.startsWith(HOTSPOT_VM_NAME_PREFIX) || vmName.startsWith(OPENJDK_VM_NAME_PREFIX)
	|| vmName.startsWith(SAPJDK_VM_NAME_PREFIX) || vmName.startsWith(GRAAL_VM_VENDOR_PREFIX)) &&
	vmVendor != null && (vmVendor.startsWith(ORACLE_VM_VENDOR_PREFIX) || vmVendor.startsWith(SUN_VM_VENDOR_PREFIX)
	|| vmVendor.startsWith(APPLE_VM_VENDOR_PREFIX) || vmVendor.startsWith(HP_VM_VENDOR_PREFIX)
	|| vmVendor.startsWith(AZUL_VM_VENDOR_PREFIX) || vmVendor.startsWith(SAP_VM_VENDOR_PREFIX)
	|| vmVendor.startsWith(ORACLE1_VM_VENDOR_PREFIX));

and doesn't consider IcedTea and AdoptOpenJDK as a supported vendor.
Adding -J-Dcom.sun.tools.visualvm.profiler.SupportAllVMs=true for 1.4.3 and -J-Dorg.graalvm.visualvm.profiler.SupportAllVMs=true for latest commit as commandline argument work around the issue.

[thurka]

Right, -J-Dcom.sun.tools.visualvm.profiler.SupportAllVMs=true is the correct workaround.

[thurka]

Can you point me to IcedTea 1.8.0_212 download? Thanks.

[Barteks2x]

I have it compiled from source on my gentoo system, but there is a bin package available on gentoo too. The ebuild points to binaries from here https://dev.gentoo.org/~gyakovlev/distfiles/ (version 3.x is java 8).

I also found links here but it appears to require manual compiling https://mail.openjdk.java.net/pipermail/distro-pkg-dev/2019-May/041681.html and some distribution specific files here http://icedtea.wildebeest.org/download/fedora/ going from https://icedtea.classpath.org/wiki/Main_Page

Now I also realized there is also some their own visualvm in that downloads page, which probably patches that. But it appears to have no binaries.

AdoptOpenJDK appears to be getting more well known now, and this was the bigger reason I reported this.

[thurka]

Thanks. I was able to use https://dev.gentoo.org/~gyakovlev/distfiles/ .

[thurka]

Fixed in VisualVM 1.4.4.