Polyglot Sampler not showing up

[fniephaus]

Describe the bug
According to this, a Polyglot Sampler tab is supposed to be visible in VisualVM 2.0.3. It seems that it's still not showing up correctly.

To Reproduce
Steps to reproduce the behavior:

1. Run polyglot --jvm --shell with a GraalVM 20.1
2. Open VisualVM on the process

Expected behavior
Polyglot Sampler tab shows up.

Screenshots
The commit shows that VisualVM checks whether jvm.getVmName().contains("GraalVM"). java.vm.name properties of GraalVM 20.1.0 releases, however, do not contain "GraalVM":

GraalVM CE 20.1

GraalVM EE 20.1

Desktop (please complete the following information):

• OS: MacOS
• JDK version GraalVM CE 20.1.0

[thurka]

I need more info, since I am not able to reproduce it. See attached screenshot.

[fniephaus]

I'm running on JDK11, apparently the vm.name does not contain it there for some reason. I'll file another bug against oracle/graal...Nonetheless, I'm not sure this is the best way to check for GraalVM.

[fniephaus]

Apart from this bringing up a bug in GraalVM, I don't think VisualVM's check is correct. You can run on an OpenJDK/LabsJDK with Graal/Truffle, and that will not have "GraalVM" in the vm.name. Maybe a check whether there is a property starting with org.graalvm is better. It feels like there should be one official and correct way to do this though.

[fniephaus]

According to @dougxc:

The property to check in JDK 11 is java.vendor.version.

[thurka]

Fixed in master.