Resolve deployment failure that is caused by insufficient memory. #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
galiacheng
commented
Jun 14, 2024
| "Standard_A1", | ||
| "Standard_A1_v2", | ||
| "Standard_F1", | ||
| "Standard_F1s", |
There was a problem hiding this comment.
Those are from https://aka.ms/aks/restricted-skus.
galiacheng
commented
Jun 14, 2024
| "label": "Credentials for WebLogic", | ||
| "elements": [ | ||
| { | ||
| "name": "listVMSizes", |
There was a problem hiding this comment.
Move the REST API query to the Basics blade, then the data may be ready when it comes to AKS blade.
galiacheng
commented
Jun 14, 2024
| "label": "Minimum node count", | ||
| "min": "[add(1, div(add(12288, mul(if(empty(basics('basicsOptional').wlsClusterSize),5,basics('basicsOptional').wlsClusterSize), 1536)), first(filter(basics('basicsRequired').listVMSizes.value, (item) => equals(item.name, steps('section_aks').clusterInfo.nodeVMSizeSelector))).memoryInMB))]", | ||
| "defaultValue": 3, | ||
| "max": 1000, |
There was a problem hiding this comment.
The same max value with AKS service.
|
Have problem to work with |
|
Hello @edburns this PR is ready for review, including |
edburns
approved these changes
Jun 26, 2024
mriccell
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to resolve deployment failure that is caused by insufficient memory.
Here are the most significant changes:
Version Update:
pom.xml: The version of thewls-on-aks-azure-marketplacehas been updated from1.0.76to1.0.78.User Interface Improvements:
weblogic-azure-aks/src/main/arm/createUiDefinition.json: Added a new section in the UI for selecting VM sizes, and updated the sliders for minimum and maximum node count to use dynamic values based on the selected VM size and the WebLogic cluster size. Also, a section for node size selection has been moved and expanded with more constraints and options. [1] [2] [3]Resource Validation:
weblogic-azure-aks/src/main/arm/scripts/inline-scripts/validateParameters.sh: Added a new functionvalidate_memory_resourcesto check if the AKS cluster has sufficient memory resources based on the number of application replicas. The function is then called in the main script. [1] [2]weblogic-azure-aks/src/main/bicep/mainTemplate.bicep,weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-validate-parameters.bicep: Passed the number of application replicas as a parameter to the validation script. [1] [2] [3]