-
Notifications
You must be signed in to change notification settings - Fork 16
Resolve deployment failure that is caused by insufficient memory. #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
3d972a5
resolve issue that caused by insufficient memory.
galiacheng 76f678e
fail fast for insufficient memory.
galiacheng 04e6db4
Merge branch 'oracle:main' into main
galiacheng 9187bf4
caculate the memory according to replicas.
galiacheng 856a26a
exclude B-series VM sizes.
galiacheng 3851bd6
enhance the UI.
galiacheng 9336048
increase pom
galiacheng f31688b
AKS restricted skus: Standard_A1_v2.
galiacheng 629b771
https://aka.ms/aks/restricted-skus
galiacheng d3797b7
make sure `aksNodeMaxCount` is greaterOrEquals `aksNodeCount`.
galiacheng 8868cc7
for testing
galiacheng 8ff6a42
use bc for the floating-point calculation.
galiacheng 40b4e9e
increase pom
galiacheng b189793
fix typos
galiacheng 20c94b9
for small VM size, may need more time to provision WLS pods.
galiacheng 69fc472
exclude the vm size that WLS does not work well in.
galiacheng 960172f
add warning message.
galiacheng 0cc4523
fix corner case
galiacheng 5d4e425
tune livenessProbe and readinessProbe for A-series VM sizes.
galiacheng aa9aa01
tune ReadinessProbe
galiacheng bd954f1
support Standard_A2_v2.
galiacheng ca0de45
do not validate application if no app is deployed.
galiacheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,14 @@ | |
"type": "Microsoft.Common.Section", | ||
"label": "Credentials for WebLogic", | ||
"elements": [ | ||
{ | ||
"name": "listVMSizes", | ||
"type": "Microsoft.Solutions.ArmApiControl", | ||
"request": { | ||
"method": "GET", | ||
"path": "[concat(subscription().id, '/providers/Microsoft.Compute/locations/',location(),'/vmSizes?api-version=2024-03-01')]" | ||
} | ||
}, | ||
{ | ||
"name": "wlsUserName", | ||
"type": "Microsoft.Common.TextBox", | ||
|
@@ -311,14 +319,81 @@ | |
"uri": "https://aka.ms/wls-aks-well-tested-version" | ||
} | ||
} | ||
}, | ||
}, | ||
{ | ||
"name": "nodeVMSizeSelector", | ||
"type": "Microsoft.Compute.SizeSelector", | ||
"label": "Node size", | ||
"toolTip": "The size of virtual machine to provision.", | ||
"recommendedSizes": [ | ||
"Standard_DS2_v2" | ||
], | ||
"constraints": { | ||
"numAvailabilityZonesRequired": 3, | ||
"zone": "3", | ||
"excludedSizes": [ | ||
"Standard_A0", | ||
"Standard_A1", | ||
"Standard_A1_v2", | ||
"Standard_F1", | ||
"Standard_F1s", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Those are from https://aka.ms/aks/restricted-skus. |
||
"Standard_B12ms", | ||
"Standard_B16als_v2", | ||
"Standard_B16as_v2", | ||
"Standard_B16ls_v2", | ||
"Standard_B16ms", | ||
"Standard_B16pls_v2", | ||
"Standard_B16ps_v2", | ||
"Standard_B16s_v2", | ||
"Standard_B1ls", | ||
"Standard_B1ms", | ||
"Standard_B1s", | ||
"Standard_B20ms", | ||
"Standard_B2als_v2", | ||
"Standard_B2as_v2", | ||
"Standard_B2ats_v2", | ||
"Standard_B2ls_v2", | ||
"Standard_B2ms", | ||
"Standard_B2pls_v2", | ||
"Standard_B2ps_v2", | ||
"Standard_B2pts_v2", | ||
"Standard_B2s", | ||
"Standard_B2s_v2", | ||
"Standard_B2ts_v2", | ||
"Standard_B32als_v2", | ||
"Standard_B32as_v2", | ||
"Standard_B32ls_v2", | ||
"Standard_B32s_v2", | ||
"Standard_B4als_v2", | ||
"Standard_B4as_v2", | ||
"Standard_B4ls_v2", | ||
"Standard_B4ms", | ||
"Standard_B4pls_v2", | ||
"Standard_B4ps_v2", | ||
"Standard_B4s_v2", | ||
"Standard_B8als_v2", | ||
"Standard_B8as_v2", | ||
"Standard_B8ls_v2", | ||
"Standard_B8ms", | ||
"Standard_B8pls_v2", | ||
"Standard_B8ps_v2", | ||
"Standard_B8s_v2" | ||
] | ||
}, | ||
"options": { | ||
"hideDiskTypeFilter": false | ||
}, | ||
"osPlatform": "Linux", | ||
"count": "[steps('section_aks').clusterInfo.aksNodeCount]", | ||
"visible": "[bool(steps('section_aks').clusterInfo.createAKSCluster)]" | ||
}, | ||
{ | ||
"name": "aksNodeCount", | ||
"type": "Microsoft.Common.Slider", | ||
"min": 1, | ||
"max": 100, | ||
"label": "Minimum node count", | ||
"min": "[add(1, div(add(12288, mul(if(empty(basics('basicsOptional').wlsClusterSize),5,basics('basicsOptional').wlsClusterSize), 1536)), first(filter(basics('basicsRequired').listVMSizes.value, (item) => equals(item.name, steps('section_aks').clusterInfo.nodeVMSizeSelector))).memoryInMB))]", | ||
"defaultValue": 3, | ||
"max": 998, | ||
"label": "Minimum node count", | ||
"showStepMarkers": false, | ||
"toolTip": "Set the minimum node count for the cluster.", | ||
"constraints": { | ||
|
@@ -329,35 +404,16 @@ | |
{ | ||
"name": "aksNodeMaxCount", | ||
"type": "Microsoft.Common.Slider", | ||
"min": "[int(steps('section_aks').clusterInfo.aksNodeCount)]", | ||
"max": 100, | ||
"min": "[add(steps('section_aks').clusterInfo.aksNodeCount,2)]", | ||
"defaultValue": 3, | ||
"max": 1000, | ||
"label": "Maximum node count", | ||
"defaultValue": 5, | ||
"showStepMarkers": false, | ||
"toolTip": "Set the maximum node count for the cluster.", | ||
"constraints": { | ||
"required": true | ||
}, | ||
"visible": "[bool(steps('section_aks').clusterInfo.createAKSCluster)]" | ||
}, | ||
{ | ||
"name": "nodeVMSizeSelector", | ||
"type": "Microsoft.Compute.SizeSelector", | ||
"label": "Node size", | ||
"toolTip": "The size of virtual machine to provision.", | ||
"recommendedSizes": [ | ||
"Standard_DS2_v2" | ||
], | ||
"constraints": { | ||
"numAvailabilityZonesRequired": 3, | ||
"zone": "3" | ||
}, | ||
"options": { | ||
"hideDiskTypeFilter": false | ||
}, | ||
"osPlatform": "Linux", | ||
"count": "[steps('section_aks').clusterInfo.aksNodeCount]", | ||
"visible": "[bool(steps('section_aks').clusterInfo.createAKSCluster)]" | ||
} | ||
] | ||
}, | ||
|
@@ -2024,7 +2080,8 @@ | |
} | ||
] | ||
}, | ||
"visible": "[and(bool(steps('section_database').enableDB), not(and(steps('section_database').databaseConnectionInfo.enablePswlessConnection0, equals(steps('section_database').databaseConnectionInfo.databaseType, 'sqlserver'))))]" }, | ||
"visible": "[and(bool(steps('section_database').enableDB), not(and(steps('section_database').databaseConnectionInfo.enablePswlessConnection0, equals(steps('section_database').databaseConnectionInfo.databaseType, 'sqlserver'))))]" | ||
}, | ||
{ | ||
"name": "enablePswlessConnection", | ||
"type": "Microsoft.Common.CheckBox", | ||
|
@@ -2258,7 +2315,7 @@ | |
"visible": "[equals(steps('section_autoScaling').autoScalingInfo.kmsMetrics, 'memory')]" | ||
} | ||
], | ||
"visible": "[bool(steps('section_autoScaling').enableAutoscaling)]" | ||
"visible": "[bool(steps('section_autoScaling').enableAutoscaling)]" | ||
} | ||
] | ||
} | ||
|
@@ -2363,4 +2420,4 @@ | |
"wlsUserName": "[basics('basicsRequired').wlsUserName]" | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the REST API query to the Basics blade, then the data may be ready when it comes to AKS blade.