Merge of latest from upstream #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onal-tests Allow PATCH as an option in functional tests
add echoln function to lib/yaml/sfYaml.class.php
This exception handler can be passed Exceptions as well as Errors. In PHP7 those both fall under the parent class 'Throwable', but for PHP5 BC it's advised to just remove the typehint entirely
Fix case for isSubclassOf method
Remove typehint from exception handler
Revert "add echoln function to lib/yaml/sfYaml.class.php"
Update sfFormField.class.php Update sfFormField.class.php remove null !== $this->error fix by e1himself Update sfFormField.class.php test travis
Fix counting of non-countable var for PHP 7.2
"PHP 7.2" instead of "PHP 7.0" in enhacements
samanthajayasinghe
approved these changes
Aug 6, 2019
Helps e.g. psalm static analysis.
Update PHPDoc - don't return "Boolean" use bool or false instead
Change mentioned current Symfony version from 4 to 5
…alse on newer versions and is deprecated since PHP 7.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some PHP 7.2 compatibility fixes