manage_pdb: Enter nested loop only when oracle_pdbs has an entry #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendanic
added a commit
to Rendanic/ansible-oracle
that referenced
this pull request
Mar 30, 2025
v4.13.0 ======= Minor Changes ------------- - Added a guide on how to install Ansible-Oracle manually on a server without Internet access. (oravirt#506) - Fix typo for sql_zauberkasten (oravirt#509) - ansible-lint: more excludes (oravirt#505) - create OMF enabled databases using dbca's -useOMF flag (oravirt#507) - manage_pdb: Enter nested loop only when oracle_pdbs has an entry (oravirt#507) - oraapex: Added missing option to copy source from remote or local host (oravirt#512) - oradb_manage_db: make hard coded folder .Scripts configurable (oravirt#511) - oradb_tzupgrade: Add orasw_meta_internal as a dependent role (oravirt#510) Bugfixes -------- - orahost_meta: move scripts_folder variable from common to orahost_meta (oravirt#504)
Merged
Rendanic
added a commit
that referenced
this pull request
Mar 30, 2025
v4.13.0 ======= Minor Changes ------------- - Added a guide on how to install Ansible-Oracle manually on a server without Internet access. (#506) - Fix typo for sql_zauberkasten (#509) - ansible-lint: more excludes (#505) - create OMF enabled databases using dbca's -useOMF flag (#507) - manage_pdb: Enter nested loop only when oracle_pdbs has an entry (#507) - oraapex: Added missing option to copy source from remote or local host (#512) - oradb_manage_db: make hard coded folder .Scripts configurable (#511) - oradb_tzupgrade: Add orasw_meta_internal as a dependent role (#510) Bugfixes -------- - orahost_meta: move scripts_folder variable from common to orahost_meta (#504)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue when you run Playbooks that call the role "oradb_manage_pdb", when these are run on non-CDB databases.
manage pdb(s)enters thewith_nested:loop, despite the conditionwhen: oracle_pdbs is defined.whenpart is evaluated after parsing the loop variables. This results in the error:msg: '''oracle_pdbs'' is undefined. ''oracle_pdbs'' is undefined'--skip-tags "pdb"when running affected playbooks (e.g. "opatch.yml").oracle_pdbsin thewith_nested:clause.I filed it as a "minor change"; feel free to classify it as a bugfix.