This repository was archived by the owner on Nov 27, 2023. It is now read-only.
Delete a database. #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillmac
reviewed
Mar 27, 2019
Contributor
phillmac
left a comment
phillmac
left a comment
There was a problem hiding this comment.
The async middleware wrapper should catch any errors, so the try-catch block should be redundant
Member
Author
Updated. Is the db_list_remove method the most ideal way of updating the db list or should I rework the db_list to check that the db exists and trim it if it doesn't? |
Contributor
|
Seems pretty logical to me the way it is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a db from the local peer.
Please let me know if anything can be better implemented and I will make the change.