changed old wiki.fitbit url links to new dev.fitbit links #110
Conversation
fitbit/api.py
Outdated
| * https://wiki.fitbit.com/display/API/API-Get-Body-Fat | ||
| * https://wiki.fitbit.com/display/API/API-Update-Fat-Goal | ||
| * https://dev.fitbit.com/docs/body/#body-fat | ||
| * https://dev.fitbit.com/docs/body/#log-body-fat |
There was a problem hiding this comment.
This method is for body fat goals, the right URLs are:
https://dev.fitbit.com/docs/body/#get-body-goals (with the fat goal-type)
https://dev.fitbit.com/docs/body/#update-body-fat-goal
fitbit/api.py
Outdated
| * https://wiki.fitbit.com/display/API/API-Get-Body-Weight-Goal | ||
| * https://wiki.fitbit.com/display/API/API-Update-Weight-Goal | ||
| https://dev.fitbit.com/docs/body/#goals |
There was a problem hiding this comment.
I think we should add the update URL here:
https://dev.fitbit.com/docs/body/#update-weight-goal
There was a problem hiding this comment.
And I think it makes sense to change the first url to this:
https://dev.fitbit.com/docs/body/#get-body-goals (with the weight goal-type)
fitbit/api.py
Outdated
| https://wiki.fitbit.com/display/API/API-Get-Activity-Daily-Goals | ||
| https://wiki.fitbit.com/display/API/API-Update-Activity-Daily-Goals | ||
| https://dev.fitbit.com/docs/activity/#activity-goals |
There was a problem hiding this comment.
Either change "APIs" to "API" on the line above or specify both the get and update URLs. Can you also modify the line above to mention that this is for the daily version of the API? Something like "Implements the following APIs (where period is daily)
https://dev.fitbit.com/docs/activity/#get-activity-goals
https://dev.fitbit.com/docs/activity/#update-activity-goals
fitbit/api.py
Outdated
| https://wiki.fitbit.com/display/API/API-Get-Activity-Weekly-Goals | ||
| https://wiki.fitbit.com/display/API/API-Update-Activity-Weekly-Goals | ||
| https://dev.fitbit.com/docs/activity/#activity-goals |
There was a problem hiding this comment.
Either change "APIs" to "API" on the line above or specify both the get and update URLs. Can you also modify the line above to mention that this is for the weekly version of the API? Something like "Implements the following APIs (where period is weekly)
https://dev.fitbit.com/docs/activity/#get-activity-goals
https://dev.fitbit.com/docs/activity/#update-activity-goals
fitbit/api.py
Outdated
| https://wiki.fitbit.com/display/API/API-Get-Food-Goals | ||
| https://wiki.fitbit.com/display/API/API-Update-Food-Goals | ||
| https://dev.fitbit.com/docs/food-logging/#get-food-goals |
There was a problem hiding this comment.
Remove the extra indent please. And add the update URL
https://dev.fitbit.com/docs/food-logging/#update-food-goal
| https://wiki.fitbit.com/display/API/API-Get-Water-Goal | ||
| https://wiki.fitbit.com/display/API/API-Update-Water-Goal | ||
| https://dev.fitbit.com/docs/food-logging/#get-water-goal |
There was a problem hiding this comment.
Please add the update URL
https://dev.fitbit.com/docs/food-logging/#update-water-goal
| and a 1d period. | ||
| https://wiki.fitbit.com/display/API/API-Get-Time-Series | ||
| https://dev.fitbit.com/docs/activity/#activity-time-series |
There was a problem hiding this comment.
We should include all the time series URLs here, and update "url" in the comment above to be "urls"
There was a problem hiding this comment.
Not really sure what you mean here? The #get-activity-time-series url anchors to literally the next line on the fitbit site. Seems redundant to include to urls for effectively the same link.
There was a problem hiding this comment.
Got it, added I think all of them here and covered the other edits in the latest commit c583c7b
| send an email to api@fitbit.com and request to have access to the Partner API | ||
| (see https://wiki.fitbit.com/display/API/Fitbit+Partner+API). For details on the resources available, see: | ||
| fill out the Private Support form here (see https://dev.fitbit.com/docs/help/). | ||
| For details on the resources available and more information on how to get access, see: |
|
@abrammer Yes, thank you for your contribution! |
2 participants
Takes care of issue #82