api: support timeout kwarg to be handed down to requests #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request introduces support for a "timeout" keyword arg to be handed down to session.request().
It is good practice to use a timeout when using requests [1]. In fact, we have observed processes getting stuck forever in the session.request() call and had to regularly restart them. A new exception "Timeout" is added. It's the users responsibility to retry if this is required.
.
I'm happy to hear about suggestions or improvements.
Thanks,
Arne
[1] http://docs.python-requests.org/en/master/user/advanced/#timeouts