Skip to content

Conversation

@awelzel
Copy link
Contributor

@awelzel awelzel commented May 8, 2016

Hi,

this pull request introduces support for a "timeout" keyword arg to be handed down to session.request().

It is good practice to use a timeout when using requests [1]. In fact, we have observed processes getting stuck forever in the session.request() call and had to regularly restart them. A new exception "Timeout" is added. It's the users responsibility to retry if this is required.
.
I'm happy to hear about suggestions or improvements.

Thanks,
Arne

[1] http://docs.python-requests.org/en/master/user/advanced/#timeouts

@awelzel
Copy link
Contributor Author

awelzel commented Dec 20, 2016

Hey, any thoughts on this?

It would be nice to not maintain this out of tree :-)

@awelzel
Copy link
Contributor Author

awelzel commented Dec 20, 2016

@brad ?

@brad
Copy link
Member

brad commented Dec 20, 2016

@awelzel Looks great! Thank you so much for the tests!

@brad brad merged commit 56cd133 into orcasgit:master Dec 20, 2016
@awelzel
Copy link
Contributor Author

awelzel commented Dec 20, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants