How to filter Non-Mandatory Reviewers in Pull Requests #146698
Replies: 1 comment
-
|
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Question
Body
Hello,
I’m facing a challenge with how reviewers are displayed in pull requests, and I’m wondering if there’s a way to make things clearer.
Here’s an example of my
CODEOWNERSsetup:If a PR modifies:
package.jsonfiles across the apps (apps/app1/package.json,apps/app2/package.json,apps/app3/package.json)app1/index.tsGitHub lists all related teams (
@team1,@team2,@team3, and@devxteam) as mandatory reviewers.However, branch protection rules require:
@devxteamfor thepackage.jsonchanges (which is often handled by the DevX team managing dependencies).@team1for theindex.tschange.In this setup, it's difficult to determine if approvals from
@team2or@team3are truly required. This becomes particularly challenging in a monorepo with 100+ apps, where identifying which approvals are still blocking the merge can be confusing and time-consuming.Why This Matters
This is especially relevant for DevX teams maintaining shared dependencies (like package.json files). They don’t always need individual app teams’ approvals to merge, but the current GitHub UI makes it appear as though their approval is required.
Additionally, our teams merge pull requests via the queue, which only allows merging when the "Merge" button turns green. With unclear UI feedback about which approvals are still required, we cannot determine when the PR is ready to be queued for merging. This slows down the process significantly.
My Question
Is there a way to:
CODEOWNERSlisted as reviewers, but provide UI feedback that clearly indicates which teams’ approvals are still blocking the merge?@devxteamforpackage.jsonchanges and@team1forindex.ts)?Any advice or solutions would be greatly appreciated!
Thank you!
Beta Was this translation helpful? Give feedback.
All reactions