Ruleset "Status checks that are required" matches the wrong source #199130
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
Reproduction
Take mui/mui-x#22792, the last commit is mui/mui-x@7e38354. The CI checks passes,
gh api repos/mui/mui-x/commits/7e38354625ec2f55af3e9bdc7be7a57038d5354b/statusreturns:{ "state": "success", "statuses": [ { "url": "https://api.github.com/repos/mui/mui-x/statuses/7e38354625ec2f55af3e9bdc7be7a57038d5354b", "avatar_url": "https://avatars.githubusercontent.com/oa/4808?v=4", "id": 48971127823, "node_id": "SC_kwDOD4Lzcc8AAAALZugcDw", "state": "success", "description": "Your tests passed on CircleCI!", "target_url": "https://circleci.com/gh/mui/mui-x/861543", "context": "ci/circleci: test_charts_benchmark", "created_at": "2026-06-15T15:18:39Z", "updated_at": "2026-06-15T15:18:39Z" },So the checks pass from the CircleCI Oauth app.
We also have rulesets for this repository https://github.com/mui/mui-x/rules/549908. There, it expects the checks to come from the CircleCI GitHub App.
Actual
In practice, people can't merge, but the UI of the PR makes it look like the checks pass:
mui/mui-x#22817
It's only once you try to merge the PR that it returns an obscure error message:
Expected
The UI above is wrong; it should clearly show that the checks are not met.
For example, it could look like this:
and the merge button could be blocked.
Beta Was this translation helpful? Give feedback.
All reactions