Concurrency group name does not contain github.event.issue.number when it should

[benja-M-1]

Select Topic Area

Question

Body

Hi,

I have a workflow that runs on issues.opened, issues.reopened, issues.edited, issue_comment.created, and issue_comment.edited.

I want to make sure that there is only one workflow running for each issue. So I tried the following at the workflow level and the job level:

concurrency:
    group: submission-${{ github.event.issue.number }}
    cancel-in-progress: true

Since every event triggering the workflow contain the issue in the payload, there should not be any issue. It works perfectly within the steps, for example.

If I open issue A and then issue B, the running workflow for issue A is cancelled. I expected to have the two workflows running, as the group name is based on the issue number. But actually, it does not. The workflow for issue A is cancelled with the following message: Canceling since a higher priority waiting request for 'submission-' exists

Did I miss something?

[jge162]

Hello and good day @benja-M-1 you need to change the group name to a unique identifier that doesn't overlap between issues. For example, you could use a combination of the issue number and a timestamp.

Pseudo code -> you need to test if it works.

submission-${{ github.event.issue.number }}-${{ timestamp }},

to ensure each workflow has a unique identifier. Because atm workflow is cancelled when a new workflow with a higher priority (a newer issue number) is triggered.

[jge162]

Pseudo code again.-> you gotta test as I have not. I think issue is with lock name and issue number.

steps:
- name: Acquire lock
  uses: actions/lock@v2
  with:
    path: lock-${{ github.event.issue.number }}
    timeout: 3600

- name: Your steps here
  ...

- name: Release lock
  uses: actions/lock@v2
  if: always()
  with:
    path: lock-${{ github.event.issue.number }}
    action: unlock

each issue will have a unique lock name based on its issue number, and workflows for different issues will not conflict with each others as with 64 and 64 above.

[benja-M-1]

I don't find this actions/lock is it an action from github's toolkit?

[jge162]

https://github.com/github/lock

[benja-M-1]

Thanks for the link :)
Your advice is to lock the issue so that nothing will happen until the workflow is done, right?
I will look at this solution, but does that prevent the running workflow from adding comments and labels to the issue? Because while it does things, the workflow adds comments to let the submitter know what is happening in the background.

[jge162]

No, the lock does not prevent the workflow from adding comments and labels to the issue. The lock is used to prevent multiple instances of the same workflow from running simultaneously for the same issue.

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬