3.12.0 incorrectly reports new version available

[NickVeit]

I upgraded to 3.12.0 on Windows 11 a few days ago. (confirmed on Help-About Jamulus).

As soon as I open the "Connection Setup" window a red text incorrectly appears on the main window stating "A Jamulus upgrade is available: go to details and downloads".

I've tried uninstalling and reinstalling.

[ann0see]

@pljones

[ann0see]

This may need a patch release if we find what results in this bug.

[pljones]

I've not seen it again since before we released 3.12.0. I've no idea what's triggering it: the version compare logic that @softins and I changed has been working okay generally -- otherwise this would be happening every time someone started Jamulus or opened the Connect dialog.

@NickVeit do you remember which Directory you had selected?

[NickVeit]

Hi. I was on "Any Genre 1" when I opened the Connect panel. I cannot test other genres right now as the damn thing is working fine this morning!

Could it be that it was having trouble with the update server (wherever the latest update number is recorded)? I had no comms issues, all servers were showing in the list as normal. I will monitor further...

[pljones]

I don't think it's the update servers - they're only checked on start up, if I remember correctly.

However, I'm pretty sure we also support "off the net" mode (i.e. where there's no access to the wider internet), which is achieved by checking every server version received for a higher release number -- that's (digits).(digits).(digits) with no trailing values. So it's possible someone is spinning up test versions they've changed the version number on to look like a later version.

Maybe we could display the the full version number as received and source IP/port.

[NickVeit]

Thanks Peter. Still working fine. It is interesting that the message did not appear until immediately the Connect panel was opened. I restarted several times to check this. I'll monitor for now...

[pljones]

Like I say, the "on start up" checks the built-in update servers. It's the "off the net" mode -- that checks whatever servers talk to it, and that only happens when you try to connect. So that's the point that "noise" can get in.

[NickVeit]

OK, terminology understood, thanks.

[softins]

@NickVeit if this is repeatable at your end, please could you capture the UDP traffic using Wireshark while it happens?

I have no idea of your skillset, so please ask if you need detailed instructions.

If you would prefer not to post the capture file, please email it to team@jamulus.io

[NickVeit]

Thanks. I may progress this if the issue returns...

[softins]

I have just noticed on Jamulus Explorer looking in Any Genre 1, a server in Italy that has popped up called "😎😎😎 Ser-Mat", which is advertising its version as 5.0.2. It has no welcome message, so no idea who runs it.

I just started a 3.12.0 client and opened the Connect dialog, which started off in Genre Jazz. I then switched to Any Genre 1, and immediately the update message appeared, presumably due to the 5.0.2 server in the fetched list.

So that explains the behaviour!

The next step is to decide what to do about it, as we can't really control what version other server operators advertise. I would be inclined not to check server versions numbers at all in the connect dialog, but only check the official update servers at startup.

[ann0see]

Thing is then how to handle isolated environments.

[softins]

Thing is then how to handle isolated environments.

I would have thought someone running an isolated environment would be aware of versions of their servers and clients and not need a notification.

[softins]

See my longer comment below about this actually being unintentional behaviour.

[AndyMcProducer]

Does Jamulus suggest updates from others in the list?
Can the directory server not have the info so when people hit it it informs the client of an update?
I'd avoid auto updates and preset paths as these are a haven for hackers to do malicious stuff.
Best how it is, opens the Jamulus Webpage or git release page. Although again these could be spoofed but
more unlikely.
Could the dir server check once a day for new release on the git then it'd be auto.

Could probs get git to update the dir server on a new release but then you'd need to keep updating the dir server with new versions.

[softins]

I have dug into the code, and this behaviour is not related to isolated environments and is not intentional. It is an unforseen side-effect of my PR #3416, in which the connect dialog sends a version request to each listed server. It didn't do so prior to that PR.

The PR was after version 3.11.0 was released, which is why this behaviour has only surfaced in release 3.12.0

The problem is that previously, the only reason to receive a CLM_VERSION_AND_OS was as a reply to the update checks.

This is the handling of that message:

CProtocol::CLVersionAndOSReceived -> connect -> CClient::CLVersionAndOSReceived -> connect -> CClientDlg::OnCLVersionAndOSReceived

In CClientDlg::OnCLVersionAndOSReceived, the update check was already there from years before, and I just added a call to send the version to the connect dialog for displaying the version of each server, without realising the side-effect of applying the version check to every returned version.

So what we actually need is a flag indicating whether we are expecting the message for an update check, or for displaying in the connect dialog, and then process the message appropriately.

Whether this issue warrants a 3.12.1 release is another conversation.

[NickVeit]

Well caught !

[softins]

Well caught !

Thanks for bringing it to our attention!

[ann0see]

Whether this issue warrants a 3.12.1 release is another conversation.

As it's a regression likely yes. But without any other fixes.

[pljones]

Yes, it definitely warrants 3.12.1.