Cancellation error #21
Closed
EdmondDantes
started this conversation in
Polls
Replies: 2 comments 2 replies
-
|
Maybe it makes sense to inherit from |
Beta Was this translation helpful? Give feedback.
2 replies
-
|
Given that there can be classes inheriting from Cancellation, I propose to prefer CancellationException is, in my opinion a bad choice for two reasons:
I don't know who voted here, but I really think this isn't a matter of just preference, but |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
At the moment, the RFC uses inheritance from \Error for the cancellation exception in order to make cancellation errors safe.
In the initial implementations, however, a new root class was used directly in the PHP core. I later removed that implementation to reduce the amount of coordination required for the code. However, it now seems to me that it was 100% correct.
12 votes ·
Beta Was this translation helpful? Give feedback.
All reactions