CompatibilityPlugin and Shared dependencies, MF sync

[crodriguez-plitzi]

Still not 100% if this should be considered a bug, so before create an issue ticket i want to confirm it

after debug for a few days i found something that i still thinking is wrong

in webpack when we import a library that its already a bundle in webpack, during the build process we call the plugin CompatibilityPlugin that basically transforms __webpack_require__ to __nested_webpack_require_${pattern.range[0]}__

my concern is that shared dependencies that were loaded by the main bundle are under __webpack_require__ and these should be exposed to the whole application if these are singleton

but testing the bundle compiled i can see things like this

if i marked that react should be singleton, why is trying to load it from the nested webpack bundle instance __nested_webpack_require_${pattern.range[0]}__ and this is why is loading the "duplicated react" instead the original from the bundle

i can understand that each nested dependency in the bundle are completely isolated, but for scenarios where dependencies are shared/singleton doesnt make sense

should this be considered a bug ?

i did some tests doing manual changes in the bundle related to this, and was able to make works react instance

from
var versions = scope[name] = scope[name] || {};
to
var versions = scope[dependencyName] = __webpack_require__.S[name][dependencyName] || scope[dependencyName] || {}; (keep on mind that this is for the scenario where __webpack_require__ is nested and we need access to the root)

doing just 1 change i was able to make it works

[alexander-akait]

Please use the issue template, respect time of other developers, thanks

Also please create reproducible test repo

[crodriguez-plitzi]

i used other template for that reason to not make it as an issue

[crodriguez-plitzi]

@alexander-akait i started this PR #15259