Failed to activate the react package

[josantana]

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.1.0
System: Mac OS X 10.11
Thrown From: react package, v0.12.10

Stack Trace

Failed to activate the react package

At Cannot read property '1' of null

TypeError: Cannot read property '1' of null
    at AtomReact.isReact (/Users/polishop/.atom/packages/react/lib/atom-react.coffee:114:44)
    at AtomReact.autoSetGrammar (/Users/polishop/.atom/packages/react/lib/atom-react.coffee:127:75)
    at AtomReact.processEditor (/Users/polishop/.atom/packages/react/lib/atom-react.coffee:307:6)
    at Workspace.module.exports.Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:267:9)
    at AtomReact.activate (/Users/polishop/.atom/packages/react/lib/atom-react.coffee:337:46)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:232:19)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:212:32
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:153:15)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package.js:205:26
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:201:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:474:21)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:457:29
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:300:16)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:452:19)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:436:46)
    at Atom.module.exports.Atom.startEditorWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/atom.js:625:21)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:12:8)
    at Object.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-bootstrap.js:23:4)
    at Module._compile (module.js:428:26)
    at Object.defineProperty.value [as .js] (/Applications/Atom.app/Contents/Resources/app.asar/src/compile-cache.js:169:21)
    at Module.load (module.js:353:32)
    at Function.Module._load (module.js:308:12)
    at Module.require (module.js:363:17)
    at require (module.js:382:17)
    at setupWindow (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:79:25)
    at window.onload (file:///Applications/Atom.app/Contents/Resources/app.asar/static/index.js:35:9)

Commands

Config

{
  "core": {
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      ".sass-cache",
      "node_modules"
    ],
    "disabledPackages": [
      "language-babel"
    ]
  },
  "react": {
    "detectReactFilePattern": ".jsx"
  }
}

Installed Packages

# User
emmet, v2.3.14
file-icons, v1.6.11
linter, v1.10.0
linter-eslint, v4.0.0
linter-scss-lint, v2.4.0
minimap, v4.16.0
minimap-hide, v0.3.0
react, v0.12.10

# Dev
No dev packages

[leskeg-zz]

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:7:11)
    at Object.extname (path.js:1433:5)
    at AtomReact.autoSetGrammar (/home/leskeg/.atom/packages/react/lib/atom-react.coffee:126:20)
    at AtomReact.processEditor (/home/leskeg/.atom/packages/react/lib/atom-react.coffee:307:6)
    at Workspace.module.exports.Workspace.observeTextEditors (/usr/lib/atom/src/workspace.js:332:9)
    at AtomReact.activate (/home/leskeg/.atom/packages/react/lib/atom-react.coffee:337:46)
    at Package.module.exports.Package.activateNow (/usr/lib/atom/src/package.js:183:20)
    at /usr/lib/atom/src/package.js:156:32
    at Package.module.exports.Package.measure (/usr/lib/atom/src/package.js:92:15)
    at /usr/lib/atom/src/package.js:149:26
    at Package.module.exports.Package.activate (/usr/lib/atom/src/package.js:146:34)
    at PackageManager.module.exports.PackageManager.activatePackage (/usr/lib/atom/src/package-manager.js:530:21)
    at /usr/lib/atom/src/package-manager.js:511:29
    at Config.module.exports.Config.transactAsync (/usr/lib/atom/src/config.js:337:18)
    at PackageManager.module.exports.PackageManager.activatePackages (/usr/lib/atom/src/package-manager.js:506:19)
    at PackageManager.module.exports.PackageManager.activate (/usr/lib/atom/src/package-manager.js:489:46)
    at /usr/lib/atom/src/atom-environment.js:765:28

[miklb]

Getting this error in 1.22 0b0

TypeError: Cannot read property 'jsxPatch' of undefined
    at AtomReact.patchEditorLangModeAutoDecreaseIndentForBufferRow (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:41:17)
    at AtomReact.patchEditorLangMode (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:107:73)
    at AtomReact.processEditor (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:308:6)
    at Workspace.observeTextEditors (/Applications/Atom Beta.app/Contents/Resources/app/src/workspace.js:725:15)
    at AtomReact.activate (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:330:46)
    at Package.module.exports.Package.activateNow (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:253:25)
    at /Applications/Atom Beta.app/Contents/Resources/app/src/package.js:225:38
    at Package.module.exports.Package.measure (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:99:21)
    at /Applications/Atom Beta.app/Contents/Resources/app/src/package.js:218:32
    at Package.module.exports.Package.activate (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:215:40)
    at PackageManager.activatePackage (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:690:42)
    at config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:665:36)
    at Config.module.exports.Config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app/src/config.js:367:24)
    at PackageManager.activatePackages (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:663:23)
    at PackageManager.activate (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:646:50)
    at /Applications/Atom Beta.app/Contents/Resources/app/src/atom-environment.js:854:36

[orktes]

Thanks for informing. Will fix asap.

On Tue, 3 Oct 2017 at 20.47, Michael Bishop ***@***.***> wrote: Getting this error in 1.22 0b0 TypeError: Cannot read property 'jsxPatch' of undefined at AtomReact.patchEditorLangModeAutoDecreaseIndentForBufferRow (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:41:17) at AtomReact.patchEditorLangMode (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:107:73) at AtomReact.processEditor (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:308:6) at Workspace.observeTextEditors (/Applications/Atom Beta.app/Contents/Resources/app/src/workspace.js:725:15) at AtomReact.activate (/Users/miklb/.atom/packages/react/lib/atom-react.coffee:330:46) at Package.module.exports.Package.activateNow (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:253:25) at /Applications/Atom Beta.app/Contents/Resources/app/src/package.js:225:38 at Package.module.exports.Package.measure (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:99:21) at /Applications/Atom Beta.app/Contents/Resources/app/src/package.js:218:32 at Package.module.exports.Package.activate (/Applications/Atom Beta.app/Contents/Resources/app/src/package.js:215:40) at PackageManager.activatePackage (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:690:42) at config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:665:36) at Config.module.exports.Config.transactAsync (/Applications/Atom Beta.app/Contents/Resources/app/src/config.js:367:24) at PackageManager.activatePackages (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:663:23) at PackageManager.activate (/Applications/Atom Beta.app/Contents/Resources/app/src/package-manager.js:646:50) at /Applications/Atom Beta.app/Contents/Resources/app/src/atom-environment.js:854:36 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#111 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAlAi9ssjMHC3bjGPTpvdhuT7sA4S81Yks5sonMngaJpZM4GbGN5> .

-- Ystävällisin terveisin, Jaakko Lukkari

[miklb]

Sorry for the abrupt bug report, was in middle of updating a few things, Atom referenced this ticket so did a quick copy/paste of stack trace. Let me know if there is anything I can test or help with on the package. I should look closer at how packages load dependencies.

Cheers.

[maxbrunsfeld]

@orktes 👋 It looks like this package was patching some of the internals of Atom's TextEditor objects, and these internals have changed recently.

The .languageMode sub-object was removed in atom/atom#15713. I was able to avoid breaking some packages which relied on this private field by defining a .languageMode getter that returns a related private object called the TokenizedBuffer. But the TokenizedBuffer has a different API than LanguageMode. The method that is most closely related to the one that this package was previously patching is called suggestedIndentForEditedBufferRow.

As a word of caution though, these internals will continue to change a bit. Using them in packages isn't a bad thing, but it means that your package may take more work to maintain because it may break when new versions of Atom are released.

Let me know if I can help in any way with getting the package working against the latest Atom.

[miklb]

Any thoughts on fixing this?

[s00500]

YEAH it is fixed =D

[jmsherry]

Errr, it's just thrown an exception for me and pointed to this ticket. Stack trace:

TypeError: Cannot read property 'jsxPatch' of undefined
    at AtomReact.patchEditorLangModeAutoDecreaseIndentForBufferRow (/Users/jamessherry/.atom/packages/react/lib/atom-react.coffee:45:17)
    at AtomReact.patchEditorLangMode (/Users/jamessherry/.atom/packages/react/lib/atom-react.coffee:111:73)
    at AtomReact.processEditor (/Users/jamessherry/.atom/packages/react/lib/atom-react.coffee:321:6)
    at Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app/src/workspace.js:725:15)
    at AtomReact.activate (/Users/jamessherry/.atom/packages/react/lib/atom-react.coffee:343:46)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app/src/package.js:253:25)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:225:38
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:21)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:218:32
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app/src/package.js:215:40)
    at PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:690:42)
    at config.transactAsync (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:665:36)
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app/src/config.js:367:24)
    at PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:663:23)
    at PackageManager.activate (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:646:50)
    at /Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:854:36

Atom 1.22.0 (on mac)

[shgiebner21]

@s00500 What did you do to arrive at your Fix?
I and others are still getting the original error.
Thanks!

[mario-subotic]

Same for me. I'm getting the same error and it started few days ago. I'm on macOS 10.13.1 and Atom 1.22.0.

[ihurenko]

Seems like that's ok after updating of react package

[weekeight]

mark

[s00500]

@shgiebner21 I just updated the package :-)

[TomYeoman]

@s00500 Fixed for myself and a colleague ( Aswell as an annoying bug where double clicking on files wouldn't actually open them, but instead just add tab for it )

Thanks!

[shgiebner21]

@s00500 @TomYeoman So just updated react to 16.1.1 (atom 1.22.0) but error persists.
Apologies for my ignorance on this one.
I even tried the old turn it off, turn it back on...