Added method for transit by entity class and id in Workflow Bundle #284
Conversation
There was a problem hiding this comment.
Please, don't put additional logic in controllers, they must be as thin as possible. In this particular case, I think it will be better to skip test case which breaks other tests and don't refactor this method(or just remove workflowManager retrieving from try block, because best practice is one try block must exist for one basic operation). It's a known issue and we plan to refactor such cases in future.
|
@turboezh , are you open to follow up on PR review notes? Thank you! |
|
@DimaSoroka, hi. Sorry for not answering long time. Unfortunately I was left company in which I was working on orocrm-based product. So now I can't continue working on this PR, mainly because have no time for it. @nixikanius is an "owner" of this work, so you may contact him if you want. |
|
Thank you for your pull request. It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/ If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits. Once you've signed the CLA, please allow for about an hour for the submission to be processed. |
|
@nixikanius - would you like to own this PR? |
|
Close pull request because it has no activity. Feel free open it if you have any question. |
5 participants
Hi.
This is a reworked version of pull request #148. All information about it you can find there. It's made at request of @nixikanius, so PR #148 may be closed.