Use mb_encode_numericentity() for PHP 8.2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following deprecation in PHP 8.2
Deprecated: mb_convert_encoding(): Handling HTML entities via mbstring is deprecated; use htmlspecialchars, htmlentities, or mb_encode_numericentity/mb_decode_numericentity instead in /home/runner/work/silverstripe-installer/silverstripe-installer/vendor/oscarotero/html-parser/src/Parser.php on line 29https://php.watch/versions/8.2/mbstring-qprint-base64-uuencode-html-entities-deprecated
I noticed this issue because html-parser is a requirement of https://github.com/oscarotero/embed which we use in our open source project
I've also added PHP 8.1 to the travis matrix with the assumption that 'nightly' will become PHP 8.2
@oscarotero Would you be able to tag 0.1.7 once this is merged. Thank you