Перенес этап изменение версии #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Перенес этап изменения версии файлов перед коммитом в git. Это снижает вероятность ошибки пропуска версий при падении.
artbear
requested changes
Feb 17, 2017
Member
artbear
left a comment
artbear
left a comment
There was a problem hiding this comment.
Полезное исправление.
Но есть небольшое замечание.
Member
There was a problem hiding this comment.
ИМХО зря убрал откат версии в исключении, это важно.
ошибка и прерывание может случиться на разных этапах.
например, падает коммит гит из-за неверных настроек гит, и файл не откатится.
Contributor
Author
There was a problem hiding this comment.
Согласен, поторопился
artbear
reviewed
Feb 17, 2017
Member
There was a problem hiding this comment.
Убери случайный лишний пробел
Member
|
Исправил пробел. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Перенес этап изменения версии файлов перед коммитом в git.
Это снижает вероятность ошибки пропуска версий при падении.