Skip to content

Conversation

@nixel2007
Copy link
Member

@nixel2007 nixel2007 commented Mar 22, 2021

При наличии в манифесте имен файлов на кириллице после подстановки версии в манифест бьется кириллица.
UTF-8 for the win

@nixel2007 nixel2007 requested a review from EvilBeaver March 22, 2021 14:22
@nixel2007
Copy link
Member Author

@EvilBeaver pls review.

@nixel2007 nixel2007 changed the base branch from master to develop March 22, 2021 14:23
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А почему NoBOM?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ммм... Почему-то у меня сложилось мнение, что безопаснее без bom, но так как это не веб и не php, то действительно лучше с bom. Поправлю.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вопрос же касается и чтения и записи, верно?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Просто 1С ждет этот манифест с BOM и обработка-хелпер генерирует его с BOM. А если не генерирует, то ошибка еще и там.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пушнул с бом

@EvilBeaver EvilBeaver merged commit 29d98b2 into develop Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants