Skip to content

prevent TableMapEventData hash from growing unbounded. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020
Merged

prevent TableMapEventData hash from growing unbounded. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/main/java/com/github/shyiko/mysql/binlog/event/LRUCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
package com.github.shyiko.mysql.binlog.event;

import java.util.LinkedHashMap;
import java.util.Map;

public class LRUCache<K,V> extends LinkedHashMap<K,V> {
private int maxSize;

// and other constructors for load factor and hashtable capacity
public LRUCache(int initialCapacity, float loadFactor, int maxSize) {
super(initialCapacity, loadFactor, true);
this.maxSize = maxSize;
}

@Override
protected boolean removeEldestEntry(Map.Entry<K, V> eldest) {
return size() > maxSize;
}
}
3 changes: 2 additions & 1 deletion src/main/java/com/github/shyiko/mysql/binlog/event/deserialization/EventDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.github.shyiko.mysql.binlog.event.EventHeader;
import com.github.shyiko.mysql.binlog.event.EventType;
import com.github.shyiko.mysql.binlog.event.FormatDescriptionEventData;
import com.github.shyiko.mysql.binlog.event.LRUCache;
import com.github.shyiko.mysql.binlog.event.TableMapEventData;
import com.github.shyiko.mysql.binlog.io.ByteArrayInputStream;

Expand Down Expand Up @@ -65,7 +66,7 @@ public EventDeserializer(
this.eventHeaderDeserializer = eventHeaderDeserializer;
this.defaultEventDataDeserializer = defaultEventDataDeserializer;
this.eventDataDeserializers = new IdentityHashMap<EventType, EventDataDeserializer>();
this.tableMapEventByTableId = new HashMap<Long, TableMapEventData>();
this.tableMapEventByTableId = new LRUCache<>(100, 0.75f, 10000);
registerDefaultEventDataDeserializers();
afterEventDataDeserializerSet(null);
}
Expand Down