Propagate all exceptions that occur in connectTimeout thread

[crispmark]

I experience an issue on production for maxwell, where an exception occurred during connection to a database that had experienced many failovers. However the exception was uncaught, and our maxwell container continued to operate in a bad state.

Going through the code here, it looks like only IOExceptions were caught by the code, causing the IllegalStateException thrown when there is already a connection to fall through the cracks. Here we force all exceptions to propagate out, and successfully terminate the application when one occurs.

[osheroff]

Like I said in the maxwell PR this is more of a band-aid to a maxwell issue but it's a good band-aid. merging.

[osheroff]

I spoke too soon in merging this. it has test failures under mysql 8/5.7. are you able to run the test suite? (MYSQL_VERSION=8.0 mvn verify). I am currently not able to as Catalina appears to have completely broken my test architecture. bastards.

[osheroff]

Tests run: 138, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 52.091 sec <<< FAILURE! - in TestSuite
testAuthenticationFailsWhenNonExistingSchemaProvided(com.github.shyiko.mysql.binlog.BinaryLogClientGTIDIntegrationTest)  Time elapsed: 0.006 sec  <<< FAILURE!
org.testng.TestException: 
Expected exception com.github.shyiko.mysql.binlog.network.AuthenticationException but got java.io.IOException: com.github.shyiko.mysql.binlog.network.AuthenticationException: Unknown database 'mbcj_test_non_existing'
	at org.testng.internal.Invoker.handleInvocationResults(Invoker.java:1497)
	at org.testng.internal.Invoker.invokeMethod(Invoke

[osheroff]

there's another test like that too

[crispmark]

I fixed this in a PR, it looks like the other exceptions it threw were subclasses of IOException, I made a change to preserve IOException types. Sorry about this.

…

On Sat, Jul 25, 2020 at 4:30 PM Ben Osheroff ***@***.***> wrote: there's another test like that too — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAL3SPI3QZQTUDGTHDYMAMDR5M6EPANCNFSM4PGHC7YQ> .