Skip to content

Added javadoc comments to Main class #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2014
Merged

Added javadoc comments to Main class #10

merged 3 commits into from
Oct 6, 2014

Conversation

Garcel
Copy link
Contributor

@Garcel Garcel commented Oct 5, 2014

Javadoc comments for:

  • Main class.
  • Main class attributes.
  • Main class methods.

@Garcel
Added javadoc comments to Main class
c506068 
Javadoc comments for:
- Main class.
- Main class attributes.
- Main class methods.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling c506068 on Garcel:garcel-branch into 2981fd5 on oskopek:master.

@oskopek
Copy link
Owner

oskopek commented Oct 5, 2014

Hello, thanks for contributing to JavaANPR! I'll add some minor comments about your changes, once you fix those I'll be glad to merge this in. Thank you for your time!

Where applicable: please change the indentation to spaces instead of tabs and remove all the trailing whitespace.

oskopek
oskopek reviewed Oct 5, 2014
View reviewed changes
src/main/java/net/sf/javaanpr/jar/Main.java Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for an empty line here.

@oskopek oskopek self-assigned this Oct 5, 2014
@oskopek oskopek added this to the 1.3.0 milestone Oct 5, 2014
@oskopek oskopek added the task label Oct 5, 2014
@Garcel
Fix for my first pull request
95e6197 
Fix for my first pull request  to fit project requirements.

-Deleted some unnecessary lines.
-Deleted some trailing white spaces.
-Deleted unnecessary indentation.
-Changed tabs for spaces.
@Garcel
Copy link
Contributor Author

Garcel commented Oct 6, 2014

Hi!

I'll submit a fix in a minute. If you still see some error just let me know and I'll fix it ASAP to fit the project requirements.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 95e6197 on Garcel:garcel-branch into 2981fd5 on oskopek:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9408bee on Garcel:garcel-branch into 2981fd5 on oskopek:master.

oskopek added a commit that referenced this pull request Oct 6, 2014
@oskopek
Merge pull request #10 from Garcel/garcel-branch
fb4c8a1 
Added javadoc comments to Main class by Garcel
@oskopek oskopek merged commit fb4c8a1 into oskopek:master Oct 6, 2014
@oskopek
Copy link
Owner

oskopek commented Oct 6, 2014

Thank you for your pull request! There are some trailing whitespaces left over, but nothing major. Again, thanks!

@oskopek
Copy link
Owner

oskopek commented Apr 6, 2015

@Garcel: If you want, add yourself to AUTHORS.adoc and submit a PR!

@oskopek oskopek modified the milestone: 2.0.0 Aug 2, 2015
@oskopek oskopek removed their assignment Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

task

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Garcel @coveralls @oskopek