Skip to content

Decouple color output from log settings #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Decouple color output from log settings #1358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/logging.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class logger
return;
}

auto const &ts = m_show_progress ? style : fmt::text_style{};
auto const &ts = m_use_color ? style : fmt::text_style{};

std::string str =
"{:%Y-%m-%d %H:%M:%S} "_format(fmt::localtime(std::time(nullptr)));
Expand Down Expand Up @@ -71,6 +71,7 @@ class logger
bool m_log_sql = false;
bool m_log_sql_data = false;
bool m_show_progress = true;
bool m_use_color = osmium::util::isatty(2);

}; // class logger

Expand Down