Allow colour `rainbow`?

[cuatim]

Hi,

maybe the colour rainbow should be allowed? Its in use, see:

https://taginfo.openstreetmap.org/tags/colour=rainbow
https://taginfo.openstreetmap.org/tags/surface%3Acolour=rainbow
https://wiki.openstreetmap.org/wiki/Key:surface:colour
https://mapcomplete.org/rainbow_crossings

I can make a PR if preferred?

Best,
C

• Error message: Unknown or invalid colour in tag 'colour'
• item 3091
• class 30914

[frodrigo]

You point the wiki page of surface:colour, not colour. rainbow is documented only for surface:colour, but Osmose do not check this key.

So, Nothing to fix. But you can add the check for support surface:colour if you want.

https://github.com/osmose-qa/osmose-backend/blob/master/plugins/Colour.validator.mapcss

[cuatim]

Hi,

I see :)

So, Nothing to fix. But you can add the check for support surface:colour if you want.

Yes, that would have been my follow up :) I will prepare a PR.

Does it not make sense to make all colour checks the same then tho? I am fine either way.

Best,
C

[Famlam]

I wouldn't add rainbow for other colour-related tags. It's a special case for surface:color, and even there it's special: while you could combine e.g. red;blue to indicate something is red and blue, it would be odd to have rainbow;blue (as rainbow is multi-color already, although I have no clue how many colors have to be present before something is a rainbow rather than multi-color :P)