Refactory of importSQLFile #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
EduFrazao
commented
Mar 14, 2022
EduFrazao
commented
- Method exported to its own file
- Method exported to its own file
- Exported to this own file - Created the async version of this feature
ospfranco
reviewed
Mar 15, 2022
ospfranco
reviewed
Mar 15, 2022
| const jsi::Value ¶ms = args[1]; | ||
| const jsi::Value &callbackHolder = args[2]; | ||
| if(!callbackHolder.isObject() || !callbackHolder.asObject(rt).isFunction(rt)) { | ||
| return {}; |
There was a problem hiding this comment.
@EduFrazao throw an error here too please and I'll merge it
There was a problem hiding this comment.
@ospfranco , its strange, to me its already throwing.
This code looks this way even after ea6de4f ?
There was a problem hiding this comment.
ah, ok, I see it now, but not on this comment, weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.