DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8

[dirk-thomas]

osrf_pycommon/osrf_pycommon/process_utils/async_execute_process_asyncio/impl.py

Line 54 in e3ceab6

@asyncio.coroutine

[dirk-thomas]

Instead of creating separate tickets for each deprecation warning I will add more here:

• osrf_pycommon/cli_utils/verb_pattern.py:44:

  DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()

• osrf_pycommon/tests/unit/test_cli_utils/test_verb_pattern.py:69:

  DeprecationWarning: Please use assertRaisesRegex instead.

[zmk5]

According to the python docs, @asyncio.coroutine should be replaced with async def. After trying this, however, I get errors that complain about the use of yield within an async definition used here:

        # Start the subprocess
        if shell is True:
            transport, protocol = yield from loop.subprocess_shell(
                protocol_factory, " ".join(cmd), cwd=cwd, env=env,
                stdout=stdout_slave, stderr=stderr_slave, close_fds=False)
        else:
            transport, protocol = yield from loop.subprocess_exec(
                protocol_factory, *cmd, cwd=cwd, env=env,
                stdout=stdout_slave, stderr=stderr_slave, close_fds=False)

[zmk5]

Additionally, I found out that >python3.6 supports asynchronous generators, but not below. Fixing the first deprecation could have CI routines that fail to build for anything lower than python3.7.

[clalancette]

Additionally, I found out that >python3.6 supports asynchronous generators, but not below. Fixing the first deprecation could have CI routines that fail to build for anything lower than python3.7.

I think we still want to maintain compatibility with at least Python 3.6 (Ubuntu Bionic). So that doesn't seem to be an option right now.

[zmk5]

That's what I thought, so the fix for the first deprecation will need to be a bit more creative haha.

[zmk5]

@ivanpauno I believe these are the issues you still found lingering with the launch bug. I'm still trying to figure out what do with the asynchronous.coroutine.

[jacobperron]

I think this was resolved in #64