Remove deprecated use of asyncio.coroutine decorator. #64
Conversation
|
This resolves #61. |
|
Dropping Python 2 and |
Just to be clear, this will only drop support for 3.4 (3.5 should still work, though I haven't tested it there). As far as the stdeb.cfg file goes, I'll definitely go ahead and change the
I'll wait for @wjwwood to weigh in here, but that sounds like a good approach to me. |
Yes, Python 2 releases must be blocked all together: |
Hm, I don't see the directive documented anywhere, and it doesn't look like it is in the list at https://github.com/astraw/stdeb/blob/57dd69cf652377af52ba307ea29c8d553e1f7b52/stdeb/util.py#L130 . |
|
#65 should fix the failing CI. |
|
Why does this break support for Python 2? I mean I'm not really attached to the Python 2 support any longer since catkin tools went python 3 only, but I'm just saying, it shouldn't be required. |
Oh, good point. I didn't actually realize how this was setup.
Yeah, you are right. I'll get rid of the changes to remove Python 2 support; we can do it separately. Thanks. |
In later versions of Python, @asyncio.coroutine is deprecated in favor of "async def". However, in order to support python back to 3.6, we also have to switch from using "yield from" to instead using "await". Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
force-pushed
the
clalancette/remove-async-coroutine
branch
from
90ad360
to
eb12b5e
Compare
The |
Ah, I see. Thanks for the info, that will be useful when I do go to remove Python 2 from this package. |
The |
In later versions of Python, @asyncio.coroutine is deprecated
in favor of "async def". However, in order to support python
back to 3.6, we also have to switch from using "yield from"
to instead using "await".
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
Note that according to the Python documentation, this should work all the way back to Python 3.5. But this definitively breaks support for Python 2, so I've removed it from Travis.