Skip to content

Conversation

audrow
Copy link
Collaborator

@audrow audrow commented Oct 15, 2020

This PR updates googletest to address warnings seen in #54.

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
@clalancette
Copy link
Contributor

The change looks OK to me, but I'm suspicious that the PR job is failing. Not sure why that is.

@audrow
Copy link
Collaborator Author

audrow commented Oct 20, 2020

I believe that there's a bug causing the wrong version of googletest to be used (when I select 1.10.0, it selects 1.7.0). I'll look into it.

-- googletest version '1.7.0' selected, of versions: '1.10.0'
-- building googletest from '/root/ros2_ws/src/osrf/osrf_testing_tools_cpp/osrf_testing_tools_cpp/vendor/google/googletest/release-1.7.0.tar.gz'...

Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@audrow
Copy link
Collaborator Author

audrow commented Nov 19, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@audrow
Copy link
Collaborator Author

audrow commented Nov 19, 2020

@clalancette, would you merge it when you have a chance? I don't have permission to.

@clalancette clalancette merged commit 585c380 into osrf:master Nov 19, 2020
@audrow audrow deleted the audrow/update-gtest branch November 20, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants