-
Notifications
You must be signed in to change notification settings - Fork 104
Model submission for Allie ground robot sensor configuration 1 and 2 from Coordinated Robotics #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/description.launch
Outdated
Show resolved
Hide resolved
Bounding box |
@nkoenig Thank you for reviewing. I corrected 2.2 of the three issues, but could use some suggestions for the third issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial assessment of the Coordinated Robotics Allie robot model is complete however there are some issues to resolve before this model can be merged and utilized in a competitive setting:
- Please resolve all noted issues in the
vehicle_topics.launch
file. - Please add an
air_pressure
sesnsor to themodel.sdf
file to match the sensor list inspecifications.md
. - Please update sensor parameters as requested by the comments in the
model.sdf
file. - Please update the VLP-16's sensing range to match the value in the specification sheet.
- Please provide validation data as it is necessary to complete the evaluation. If not provided, the model's maximum velocity will be limited to 1m/s and battery life set to 60min. When the model validation data can be provided later, please submit a PR updating the model.
Please address the issues noted above in this pull request. Once the above issues are fixed, your submission will move on to the next review stage!
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
submitted_models/coro_allie_sensor_config_1/launch/vehicle_topics.launch
Outdated
Show resolved
Hide resolved
@acschang What are you looking for beyond what was provided / linked in the specifications.md? Calculations, datalogs, videos, spreadsheets, etc. are provided for the values. |
Please refer to the Model Preparation Guide. We appear to be missing motion and endurance validation data for this model at the moment. If you've uploaded this data and the issue is locating it on my end, please let me know. Edit: It looks like the validation data is present in the |
@knoedler I've looked over the validation data but I can't find where battery voltage is recorded for your endurance test. Can you please direct me to where the battery voltage is recorded? The velocity/acceleration data for motion looks good! |
Thank you for taking a look. |
I can see where you have the voltmeter plugged in although I'm unable to discern the voltage clearly from the video. Unfortunately this endurance test does not meet the requirements laid out in the Simulation Model Preparation Guide so we cannot accept the model with the current battery configuration. You may re-do the endurance experiment and display the voltmeter before and after the 20 minute endurance experiment or we will limit the vehicle's endurance to 60 minutes of operation. The data provided for motion is sufficient so regardless of your choice, the motion characteristics will remain as-is. |
I re-ran the endurance test. The specifications.md has been updated with a link to the new video and the calculations have been updated. Humorously, the video of the voltmeter takes some contortions to read as only a few segments are flashed on at once and it cycles through various displays. Luckily, the logging to the rosbag worked so the voltmeter portion of the video can be ignored. The new rosbag and and voltage.csv are in the same google drive location. |
Continued in #863 |
This is a four wheel skid steer robot based on our "Allie" robot.