Deployment bucket error occurs in v3.59.2

[JP-Dhabolt]

After updating to v3.59.2 (from v3.59.1), deployments fail with Deployment bucket is not in the same region as the lambda function.

Expectation would be that deployments continue as expected. It would appear the latest changes to move from getBucketLocation to headBucket introduced a regression.

We have reverted to v3.59.1 and deployments are successful again. I have also confirmed that the bucket and the lambda function are indeed in the same region (us-east-1). We have an explicitly provided bucket name if that helps in triaging.

If I can, I will try to do some additional triage locally and post back here if I find anything.

[GrahamCampbell]

#119

[mnapoli]

Thanks for the report, latest release reverts that https://github.com/oss-serverless/serverless/releases/tag/v3.59.3

[JP-Dhabolt]

@mnapoli / @GrahamCampbell
I did some additional triage with v3.59.2 and determined the issue is due to the defined version range of aws-sdk v2: https://github.com/oss-serverless/serverless/blob/main/package.json#L51

The application we are using has been around for years, and so had the minimum defined version of aws-sdk locked. I verified that bumping this to 2.1506.0 (the last version that modified headBucket), it behaves as expected.

I think this means you can re-introduce the headBucket change if it includes a minimum version bump of the SDK to at least 2.1506.0, though I think it would make sense to make the minimum version the terminal release (2.1692.0) to avoid similar scenarios.

[mnapoli]

Thank you for digging into this! @Engerim happy to re-merge the original changes with the dependency update if you're up for it?

[Engerim]

Sorry only read my notifications today, will raise an pr again with also the raised aws-sdk version. I had initially only checked the latest sources of the aws-sdk. Sorry for that